fix: update linter

.github/workflows/lint.yml

@@ -18,4 +18,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.53.3
+          version: v1.54.1

.golangci.yml

@@ -5,6 +5,10 @@ linters-settings:
     locale: US
   gci:
     local-prefixes: github.com/evilmartians/lefthook
+  revive:
+    rules:
+      - name: unused-parameter
+        disabled: true
 
 linters:
   disable-all: true

Makefile

@@ -20,7 +20,7 @@ bench:
 
 bin/golangci-lint:
 	@test -x $$(go env GOPATH)/bin/golangci-lint || \
-		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin v1.53.3
+		curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $$(go env GOPATH)/bin v1.54.1
 
 lint: bin/golangci-lint
 	$$(go env GOPATH)/bin/golangci-lint run

cmd/version.go

@@ -8,7 +8,7 @@ import (
 	"github.com/evilmartians/lefthook/internal/version"
 )
 
-func newVersionCmd(opts *lefthook.Options) *cobra.Command {
+func newVersionCmd(_opts *lefthook.Options) *cobra.Command {
 	var verbose bool
 
 	versionCmd := cobra.Command{

internal/lefthook/lefthook.go

@@ -90,11 +90,7 @@ func (l *Lefthook) cleanHook(hook string, force bool) error {
 
 	// Just remove lefthook hook
 	if l.isLefthookFile(hookPath) {
-		if err = l.Fs.Remove(hookPath); err != nil {
-			return err
-		}
-
-		return nil
+		return l.Fs.Remove(hookPath)
 	}
 
 	// Check if .old file already exists before renaming.

internal/lefthook/run_test.go

@@ -12,19 +12,19 @@ import (
 
 type GitMock struct{}
 
-func (g GitMock) Cmd(cmd string) (string, error) {
+func (g GitMock) Cmd(_cmd string) (string, error) {
 	return "", nil
 }
 
-func (g GitMock) CmdArgs(args ...string) (string, error) {
+func (g GitMock) CmdArgs(_args ...string) (string, error) {
 	return "", nil
 }
 
-func (g GitMock) CmdLines(cmd string) ([]string, error) {
+func (g GitMock) CmdLines(_cmd string) ([]string, error) {
 	return nil, nil
 }
 
-func (g GitMock) RawCmd(cmd string) (string, error) {
+func (g GitMock) RawCmd(_cmd string) (string, error) {
 	return "", nil
 }
 

internal/lefthook/runner/runner.go

@@ -314,7 +314,6 @@ func (r *Runner) runCommands() {
 		if len(r.RunOnlyCommands) == 0 || slices.Contains(r.RunOnlyCommands, name) {
 			commands = append(commands, name)
 		}
-
 	}
 
 	sort.Strings(commands)

internal/lefthook/runner/runner_test.go

@@ -18,7 +18,7 @@ import (
 
 type TestExecutor struct{}
 
-func (e TestExecutor) Execute(opts ExecuteOptions, out io.Writer) (err error) {
+func (e TestExecutor) Execute(opts ExecuteOptions, _out io.Writer) (err error) {
 	if opts.args[0] == "success" {
 		err = nil
 	} else {
@@ -28,7 +28,7 @@ func (e TestExecutor) Execute(opts ExecuteOptions, out io.Writer) (err error) {
 	return
 }
 
-func (e TestExecutor) RawExecute(command []string, out io.Writer) error {
+func (e TestExecutor) RawExecute(_command []string, _out io.Writer) error {
 	return nil
 }
 

internal/lefthook/uninstall.go

@@ -47,11 +47,7 @@ func (l *Lefthook) Uninstall(args *UninstallArgs) error {
 		}
 	}
 
-	if err := l.Fs.RemoveAll(l.repo.RemotesFolder()); err != nil {
-		return err
-	}
-
-	return nil
+	return l.Fs.RemoveAll(l.repo.RemotesFolder())
 }
 
 func (l *Lefthook) deleteHooks(force bool) error {