Unable to start project due to typos in filenames and incorrect line endings

[michalvarys]

Following imports doesn't match the filenames CouponValidator DiscountCalculator

evershop/packages/evershop/src/modules/promotion/bootstrap.js

Lines 3 to 4 in 29c834a

	const { validateCoupon } = require('./services/couponValidator');
	const { calculateDiscount } = require('./services/discountCalculator');

-const { validateCoupon } = require('./services/couponValidator');
-const { calculateDiscount } = require('./services/discountCalculator');
+const { validateCoupon } = require("./services/CouponValidator");
+const { calculateDiscount } = require("./services/DiscountCalculator");

CRLF line ending for the file evershop causes an error

$ evershop dev
/usr/bin/env: ‘node\r’: No such file or directory
error Command failed with exit code 127.

It starts working after manually changing the line ending to LF

Ubuntu 20.04.5 LTS;
NPM 9.8.1;

[treoden]

Hi @michalvarys ,

Yeah, with the latest release, the name of those 2 files changed (camel cases). I think your git was not case sensitive and it does not update the file name in this case.

[claudiolor]

Hi @treoden,

I faced the same issue with importing the CouponValidator and DiscountCalculator modules also creating a project via npx.

Looking at these files in the Github repository it looks like they still have the Pascal case naming, so probably they still need to be renamed.

[tiberiuichim]

I created a PR for this. I find the notion of seeing this sort of issue in a release of Evershop a bit troubling and makes me raise the question: is this project right for me?

[treoden]

Hi,

That was a stupid mistake from me. Thanks for the PR @tiberiuichim