Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The progress of translations shows incorrect value #386

Closed
vvadymk opened this issue Jul 11, 2023 · 0 comments · Fixed by #387
Closed

The progress of translations shows incorrect value #386

vvadymk opened this issue Jul 11, 2023 · 0 comments · Fixed by #387
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@vvadymk
Copy link
Contributor

vvadymk commented Jul 11, 2023 •
edited
Loading

Describe the bug
The progress of translations round up therefore if we have 1 untranslated terms we will have 100% of translations, which isn' t correct.
This problem is due to rounding up instead of rounding down.
To Reproduce
Steps to reproduce the behavior:

  1. Import 500 terms where 499 are translated
  2. Pay attention at the progress of translation

Expected behavior
We could see 99% of the translation progress

** Environment (please complete the following information):**

  • Device: Desktop
  • OS: MacOS Ventura 13.4.1
  • Browser Brave
  • Version 0.19.7
@vvadymk vvadymk added bug Something isn't working help wanted Extra attention is needed labels Jul 11, 2023
@vvadymk vvadymk mentioned this issue Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change translation progress rounding to down vvadymk/ever-traduora
1 participant
@vvadymk