-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow makefile addition to build Go wasip1 .wasm binary #3779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2024
This was referenced Jul 22, 2024
This was referenced Jul 23, 2024
This was referenced Sep 17, 2024
This was referenced Sep 22, 2024
[Snyk] Upgrade: , , , , esbuild, rimraf, rollup, typescript, vitest
leonardoadame/Affiliate-tech#812
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Go supporting wasi (wasip1 os) now (as mentioned here: https://go.dev/blog/wasi & here #3300), this PR adds a build option to the Makefile for a wasip1 wasm build.
Tested & runs prefectly fine with
wasmtime
:^^ Heads up! In case of wasmtime, the
dir
arg needs exactly this content:.::/
- which means.
(local dir) maps to (::
)/
(root virtual filesystem).The advantage of building wasi over the current wasm build (
platform-wasm
) is that the wasi build can run natively using CLI tools likewasmtime
, and running in a node / JS environment is also compatible with several wasi browser runtimes. So: no need for the specificesbuild-wasm
package, as one can execute the built.wasm
with e.g.@runno/wasi
or any other wasi implementation.To run the same thing not on CLI but in a browser, all you need is this in a
<script type="module" ...
: