Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS API: sourcemap:true causes esbuild to fail #130

Closed
rsms opened this issue May 22, 2020 · 0 comments
Closed

JS API: sourcemap:true causes esbuild to fail #130

rsms opened this issue May 22, 2020 · 0 comments

Comments

@rsms
Copy link

rsms commented May 22, 2020

  • Repro: use the js api, calling esbuild.build({ ... sourcemap:true })
  • Expected: esbuild to be invoked with --sourcemap flag
  • Actual: esbuild is invoked with --sourcemap=true which causes an error

esbuild 0.3.6, nodejs v12.16.3, macOS 10.14

Likely source of issue:

if (options.sourcemap) flags.push(`--sourcemap=${options.sourcemap === true ? defaults.sourcemap : options.sourcemap}`);

@evanw evanw closed this as completed in 75d0b1f May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant