Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode-13.0.0 npm package has been deprecated #1003

Closed
Zuckjet opened this issue Mar 19, 2021 · 5 comments · Fixed by #1004
Closed

unicode-13.0.0 npm package has been deprecated #1003

Zuckjet opened this issue Mar 19, 2021 · 5 comments · Fixed by #1004

Comments

@Zuckjet
Copy link
Contributor

Zuckjet commented Mar 19, 2021

"unicode-13.0.0": "0.8.0"

unicode-13.0.0 npm package has been deprecated, see details.

Recommend to use @unicode/unicode-13.0.0

@evanw
Copy link
Owner

evanw commented Mar 19, 2021

I think this package is unused. I will try removing it.

@Zuckjet
Copy link
Contributor Author

Zuckjet commented Mar 19, 2021

I think this package is unused. I will try removing it.

One more question, I see this comment in unicode.go:

// This file was automatically generated by gen-unicode-table.js. Do not edit.

In gen-unicode-table.js:

const idStart = require(`unicode-${version}/Binary_Property/ID_Start/code-points`);
const idContinue = require(`unicode-${version}/Binary_Property/ID_Continue/code-points`);

You mean unicode.go will not be changed any more ?

@evanw
Copy link
Owner

evanw commented Mar 19, 2021

Ah that's where it was. I searched for unicode-13.0.0 and it came up blank.

@Zuckjet
Copy link
Contributor Author

Zuckjet commented Mar 19, 2021

Sorry for bothering, it seems I should send a PR for this small changes, but I think you may more like someone send a issue not a direct PR.

@evanw
Copy link
Owner

evanw commented Mar 19, 2021

No worries. I don't mind either way. I'll fix it soon. Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants