uglify tests: enable issue_4464_3, which now works

evanw · Dec 22, 2021 · c370315 · c370315
1 parent 228478c
commit c370315
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/internal/bundler/bundler_default_test.go b/internal/bundler/bundler_default_test.go
@@ -5156,3 +5156,29 @@ func TestToESMWrapperOmission(t *testing.T) {
 		},
 	})
 }
+
+// This is coverage for a past bug in esbuild. We used to generate this, which is wrong:
+//
+//   let x = function(foo) {
+//     var foo2;
+//     return foo2;
+//   };
+//
+func TestNamedFunctionExpressionArgumentCollision(t *testing.T) {
+	loader_suite.expectBundled(t, bundled{
+		files: map[string]string{
+			"/entry.js": `
+				let x = function foo(foo) {
+					var foo;
+					return foo;
+				}
+			`,
+		},
+		entryPaths: []string{"/entry.js"},
+		options: config.Options{
+			Mode:         config.ModePassThrough,
+			AbsOutputDir: "/out",
+			MangleSyntax: true,
+		},
+	})
+}
diff --git a/internal/bundler/snapshots/snapshots_loader.txt b/internal/bundler/snapshots/snapshots_loader.txt
@@ -434,6 +434,14 @@ var o=123;console.log(o,"no identifier in this file should be named W, X, Y, or
 ---------- /out/require.js ----------
 var i=r((t,e)=>{e.exports=123});var s=i();console.log(s,"no identifier in this file should be named A, B, C, or D");
 
+================================================================================
+TestNamedFunctionExpressionArgumentCollision
+---------- /out/entry.js ----------
+let x = function(foo) {
+  var foo;
+  return foo;
+};
+
 ================================================================================
 TestRequireCustomExtensionBase64
 ---------- /out.js ----------

diff --git a/scripts/uglify-tests.js b/scripts/uglify-tests.js
@@ -239,7 +239,6 @@ async function test_case(esbuild, test, basename) {
       'const.js: use_before_init_3',
       'destructured.js: funarg_side_effects_2',
       'destructured.js: funarg_side_effects_3',
-      'drop-unused.js: issue_4464_3',
       'let.js: issue_4225',
       'let.js: issue_4229',
       'let.js: issue_4245',