Fixed wrong byte order on big endian platforms (e.g. powerpc). #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Supporting big endian is a good idea, but I'm afraid endian.h is not cross-platform. Please wrap these calls inside an appropriate #ifdef, or look at the gzip module to see how Nginx handles endianness issues. |
|
I have updated the code to be more cross platform, hope it fits better now. |
|
Neat, thanks! I'll get this merged in. |
evanmiller
added a commit
that referenced
this pull request
Apr 11, 2014
Fixed wrong byte order on big endian platforms (e.g. powerpc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZIP file format is little endian. When using the mod_zip module on big endian platforms, the code did not work (the produced archive was invalid). This code fixes this behavior and was tested on a powerpc Linux platform.