Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Reader to InputStream" should recommend Commons IO's ReaderInputStream #10382

Closed
Marcono1234 opened this issue Jan 2, 2021 · 2 comments
Closed

"Reader to InputStream" should recommend Commons IO's ReaderInputStream #10382

Marcono1234 opened this issue Jan 2, 2021 · 2 comments
Labels
on-jira triaged Issues reviewed by a dev and considered valid. Will be added in Jira.

Comments

@Marcono1234
Copy link

The article "Java – Reader to InputStream" should use and recommend Commons IO's ReaderInputStream since that is currently the most efficient solution available.

See also google/guava#5376
@kwoyke kwoyke added triaged Issues reviewed by a dev and considered valid. Will be added in Jira. and removed in progress labels Oct 19, 2021
@kwoyke
Copy link
Contributor

kwoyke commented Nov 26, 2021

Hi @Marcono1234 ,
Thanks for the feedback. We've updated the code and the article.

@kwoyke kwoyke closed this as completed Nov 26, 2021
@Marcono1234
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on-jira triaged Issues reviewed by a dev and considered valid. Will be added in Jira.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwoyke @Marcono1234 @collaboratewithakash