Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak Grouping Depends on Order of samples #749

Open
PMSeitzer opened this issue Sep 12, 2024 · 0 comments
Open

Peak Grouping Depends on Order of samples #749

PMSeitzer opened this issue Sep 12, 2024 · 0 comments

Comments

@PMSeitzer
Copy link
Collaborator

This was discovered during #746

peakdetector always sorts samples by natural order, while the peaks search in the GUI was using the order from the main window.

However, there is an issue with the peak group formation algorithm, where apparently the order of the samples affects the peak groups. This is either in EIC::eicMerge() or EIC::mergedEICToGroups(), though the latter seems less likely since there is a
sort(allPeak...) step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant