Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out PeakContainer merging step from EIC::mergedEICToGroups() #686

Closed
PMSeitzer opened this issue Nov 18, 2023 · 2 comments
Closed

Factor out PeakContainer merging step from EIC::mergedEICToGroups() #686

PMSeitzer opened this issue Nov 18, 2023 · 2 comments
Assignees
@PMSeitzer
Labels
cleanup minor refactor, code cleanup, favorable reorganization enhancement

Comments

@PMSeitzer
Copy link
Collaborator

This will allow this merging to be performed in other contexts, e.g. by mzkitcpp as per https://github.com/calico/mass_spec/issues/1126
@PMSeitzer PMSeitzer added enhancement cleanup minor refactor, code cleanup, favorable reorganization labels Nov 18, 2023
@PMSeitzer PMSeitzer self-assigned this Nov 18, 2023
@PMSeitzer
Copy link
Collaborator Author

This might also be a good excuse to fix some code issues - for example, map<int, PeakContainer> might be changed to vector<PeakContainer> where the int key is the position in the vector.

Need to create a test to ensure that the refactor works well.

@PMSeitzer PMSeitzer mentioned this issue Nov 20, 2023
Open
@PMSeitzer
Copy link
Collaborator Author

Completed as of eugenemel/maven_core@7bd8654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PMSeitzer PMSeitzer

Labels
cleanup minor refactor, code cleanup, favorable reorganization enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PMSeitzer