Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate applyOptions and getDefaultOptions #131

Closed
4 tasks
clabe45 opened this issue Jul 17, 2022 · 2 comments
Closed
4 tasks

Deprecate applyOptions and getDefaultOptions #131

clabe45 opened this issue Jul 17, 2022 · 2 comments
Assignees
@clabe45
Labels
priority:low type:refactor

Comments

@clabe45
Copy link
Collaborator

clabe45 commented Jul 17, 2022 •
edited
Loading

  • Deprecate applyOptions in util.ts
  • Deprecate Movie#getDefaultOptions, setting the properties from the options manually.
  • Deprecate getDefaultOptions for all layers
  • Deprecate getDefaultOptions for all effects
@clabe45 clabe45 moved this to Todo in Simplify API Jul 17, 2022
@clabe45 clabe45 changed the title Remove getDefaultOptions Deprecate getDefaultOptions Jul 17, 2022
@clabe45
Copy link
Collaborator Author

clabe45 commented Aug 1, 2022

This would mess up inheriting options from superclasses (unless if anyone can think of another way)

@clabe45 clabe45 closed this as completed Aug 1, 2022
Repository owner moved this from Todo to Done in Simplify API Aug 1, 2022
@clabe45
Copy link
Collaborator Author

clabe45 commented Sep 18, 2022

Taking a second look, there is no need to know the superclass's options, because the superclass is responsible for setting its own options. applyOptions and getDefaultOptions should be deprecated.

@clabe45 clabe45 reopened this Sep 18, 2022
@clabe45 clabe45 changed the title Deprecate getDefaultOptions Deprecate applyOptions and getDefaultOptions Sep 18, 2022
@clabe45 clabe45 self-assigned this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clabe45 clabe45

Labels
priority:low type:refactor
Projects
No open projects
Simplify API
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clabe45