Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SX Style overrides do not work on full screens #599

Closed
joebochill opened this issue Jun 17, 2024 · 1 comment
Closed

SX Style overrides do not work on full screens #599

joebochill opened this issue Jun 17, 2024 · 1 comment
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Milestone

Comments

@joebochill
Copy link
Collaborator

Describe the bug / expected behavior

Providing sx prop to a full screen component is ignored. The sx prop should be properly spread to the base component and applied.

What are the steps to reproduce?

  1. Render the FullScreen login component
  2. Add sx style rule to change a background color for example
  3. Observe that no style changes are reflected

Code snippet / Link to minimum reproduction example

    <LoginScreen
        projectImage={<img src={EatonLogo} alt="logo" style={{ maxHeight: 80 }} />}
        header={<DebugComponent />}
        errorDisplayConfig={{
            mode: 'message-box',
            messageBoxConfig: {
                dismissible: true,
                position: 'top',
            },
        }}
        sx={{
            backgroundColor: 'orange',
            '& .MuiCardContent-root':{
                backgroundColor: 'red',
                '::-webkit-scrollbar': {
                    width: 0
                }
            }
        }}
    />

Suggested fix

Destructure the sx prop and pass it through to the Base components.

@joebochill joebochill added bug Something not working as expected needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Jun 17, 2024
@surajeaton surajeaton removed the needs-review Issues that we would like to revisit/review label Jun 26, 2024
@manojleaton manojleaton self-assigned this Jul 29, 2024
@manojleaton manojleaton added this to the 4.0.3 milestone Jul 31, 2024
@ektaghag-eaton
Copy link
Contributor

This is fixed here #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Development

No branches or pull requests

4 participants