Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload EULA should not be tied to checkbox status #549

Closed
joebochill opened this issue Feb 23, 2024 · 2 comments
Closed

Reload EULA should not be tied to checkbox status #549

joebochill opened this issue Feb 23, 2024 · 2 comments
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected

Comments

@joebochill
Copy link
Collaborator

joebochill commented Feb 23, 2024

Describe the bug / expected behavior

The EULA base screen currently determines whether to show the 'Reload' component based on the disabled state of the checkbox. The checkbox enabled/disabled status is completely unrelated to whether or not the EULA successfully loaded or not.

What are the steps to reproduce?

  1. https://github.com/etn-ccis/blui-react-workflows/blob/dev/login-workflow/src/screens/EulaScreen/EulaScreenBase.tsx#L74

Suggested fix

Add a new prop to the EULAScreenBase:

refreshConfig?: {
    onRefresh?: () => void;
    showRefreshButton?: boolean;
    refreshButtonLabel?: string;
}

Anything else to add?

The Retry button also has a hardcoded english label with no option to change — this needs to be fixed (see suggestion)

@joebochill joebochill added bug Something not working as expected needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Feb 23, 2024
@surajeaton surajeaton removed the needs-review Issues that we would like to revisit/review label Feb 28, 2024
@ektaghag-eaton
Copy link
Contributor

@priyankakmEaton Check the implementation of RN side and add.

@ektaghag-eaton
Copy link
Contributor

Fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Development

No branches or pull requests

4 participants