Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Configuration does not support Redis Passwords that Contain # #900

Closed
RobertKeyser opened this issue Jul 18, 2022 · 0 comments · Fixed by #1104
Closed

Configuration does not support Redis Passwords that Contain # #900

RobertKeyser opened this issue Jul 18, 2022 · 0 comments · Fixed by #1104
Assignees
Labels
bug Something isn't working

Comments

@RobertKeyser
Copy link
Contributor

RobertKeyser commented Jul 18, 2022

Bug Description

When instantiating an instance of Fidesops where your Redis password contains a pound sign, #, Fidesops successfully attempts a connection, but then fails out with an error message suggesting that it tried to use everything that preceded the # as a port, which is could not treat as an integer.

For example, if I set the password as redispass#hello, the error message states ValueError: Port could not be cast to integer value as 'redispass'. Interestingly enough, if I give it a password that's different than the one on the Redis instance, it fails out saying that the password is wrong.

Steps to Reproduce

  1. spin up an instance of Redis that has a password of redispass#abc
  2. configure a new Fidesops instance to use the password of redispass#abc via the env var FIDESOPS__REDIS__PASSWORD
  3. launch the Fidesops instance and review the logs.

Expected behavior

The Fidesops instance connects to the database and does not encounter any Redis related errors.

Screenshots

Environment

  • Version: 1.6.3
  • OS:
  • Python Version:
  • Docker Version: a few, including 20.10.11

Additional context

At least for Elasticache (and other engines, I believe), Redis should support any valid password. https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/auth.html#auth-overview

@RobertKeyser RobertKeyser added the bug Something isn't working label Jul 18, 2022
@seanpreston seanpreston assigned sanders41 and unassigned seanpreston Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants