Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fidesops Can't Login: Base64 Regression #809

Closed
pattisdr opened this issue Jul 6, 2022 · 0 comments · Fixed by #820
Closed

Fidesops Can't Login: Base64 Regression #809

pattisdr opened this issue Jul 6, 2022 · 0 comments · Fixed by #820
Assignees
Labels
bug Something isn't working

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Jul 6, 2022

Bug Description

The Fideslib models PR #700 which started using FidesUser instead of FidesopsUser introduced a regression so now we're no longer expecting passwords to be base64 encoded in the API. https://github.com/ethyca/fidesops/pull/749/files

We're in a weird state right now, because the front end is base64 encoding the passwords before sending them to the backend but the backend is now assuming they are being sent plain, because we switched to using a Fideslib schema that didn't have the base64 code.

Two things:

Steps to Reproduce

  1. Do this...
  2. Then This...

Expected behavior

A description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@pattisdr pattisdr added the bug Something isn't working label Jul 6, 2022
@pattisdr pattisdr changed the title Fidesops Password Base64 Regression Fidesops Base64 Regression Jul 6, 2022
@pattisdr pattisdr changed the title Fidesops Base64 Regression Fidesops Can't Login: Base64 Regression Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants