Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

LOG_PII and DEV_MODE require case sensitive values #710

Closed
RobertKeyser opened this issue Jun 24, 2022 · 0 comments · Fixed by #712
Closed

LOG_PII and DEV_MODE require case sensitive values #710

RobertKeyser opened this issue Jun 24, 2022 · 0 comments · Fixed by #712
Assignees
Labels
bug Something isn't working

Comments

@RobertKeyser
Copy link
Contributor

RobertKeyser commented Jun 24, 2022

Bug Description

I attempted to set LOG_PII and DEV_MODE to true by setting the environment variables FIDESOPS__LOG_PII and FIDESOPS__DEV_MODE; however, the startup logs still showed that both values were false. When I changed the value to True (note the capital T), it finally enabled LOG_PII and DEV_MODE.

Here is a snippet of my k8s deployment where I set the environment variables:

### Not Working ###
          env:
            - name: FIDESOPS__LOG_PII
              value: "true"
            - name: FIDESOPS__DEV_MODE
              value: "true"
              
### Working ###
          env:
            - name: FIDESOPS__LOG_PII
              value: "True"
            - name: FIDESOPS__DEV_MODE
              value: "True"

I'm assuming this also impacts FIDESOPS__HOT_RELOAD, but I haven't tested it. I also haven't tested when the values are set in the toml instead.

Steps to Reproduce

  1. Spin up a new Fidesops instance and set FIDESOPS__LOG_PII to true

Expected behavior

LOG_PII and DEV_MODE should be set irrespective of casing of the environment variable. I'd expect any of the following to work (though all lowercase is the most important).

  • true
  • True
  • TRUE
  • false
  • False
  • FALSE

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version: 1.6.0
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants