Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[SaaS Connectors] Inconsistent results with SaaS connector integration tests #472

Closed
galvana opened this issue May 5, 2022 · 0 comments · Fixed by #473
Closed

[SaaS Connectors] Inconsistent results with SaaS connector integration tests #472

galvana opened this issue May 5, 2022 · 0 comments · Fixed by #473
Assignees
@galvana
Labels
bug Something isn't working

Comments

@galvana
Copy link
Collaborator

galvana commented May 5, 2022 •
edited by mfbrown
Loading

Bug Description

The data creation portion of the erasure integration tests for SaaS connectors yields inconsistent results. This is caused by 3rd party APIs taking some time for data created via the create endpoints to be available from the read endpoints.

Steps to Reproduce

Add the run unsafe ci checks label to a PR and make note of the test results. Currently seeing issues with the following connectors:

  • Hubspot (erasure)
  • Segment (erasure)
  • Sentry (erasure)
  • Mailchimp (access)

Expected behavior

The test fixtures should wait until data is available on the read endpoints before continuing with the actual tests.
@galvana galvana added the bug Something isn't working label May 5, 2022
@galvana galvana mentioned this issue May 5, 2022
Merged
6 tasks
@galvana galvana linked a pull request May 5, 2022 that will close this issue
Fixing inconsistent SaaS connector integration tests #473
Merged
6 tasks
@galvana galvana assigned PSalant726 and unassigned PSalant726 May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@galvana galvana

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing inconsistent SaaS connector integration tests ethyca/fidesops
2 participants
@galvana @PSalant726