Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[Misc DevOps] make mypy is failing on M1 Macs #392

Closed
seanpreston opened this issue Apr 13, 2022 · 4 comments · Fixed by #630
Closed

[Misc DevOps] make mypy is failing on M1 Macs #392

seanpreston opened this issue Apr 13, 2022 · 4 comments · Fixed by #630
Labels
bug Something isn't working

Comments

@seanpreston
Copy link
Contributor

seanpreston commented Apr 13, 2022

Bug Description

make mypy is failing on M1 Macs:

adam@Adams-MacBook-Pro fidesops % mypy .
mypy.ini:7: error: Error importing plugin "pydantic.mypy": cannot import name 'TypeVarDef' from 'mypy.types'
(/Users/adam/.pyenv/versions/3.9.11/envs/initial_dev3_9_11/lib/python3.9/site-packages/mypy/types.cpython-39-darwin.so)  [misc]
    plugins = pydantic.mypy, sqlmypy
    ^
Found 1 error in 1 file (errors prevented further checking)

Steps to Reproduce

  1. Run make mypy on a Mac with an M1 chip

Expected behavior

Mypy should run successfully and output something like:

root@de889783508e:/fidesops# mypy --ignore-missing-imports src/
Success: no issues found in 146 source files

See secretanalytics/secret-sdk-python#7 for extra context

@seanpreston seanpreston added the bug Something isn't working label Apr 13, 2022
@sanders41
Copy link
Contributor

Any chance these are related #367? Bumping the Pydantic version may help. It would also need to be bumped on the fides side to prevent a conflict with fidesctl.

@seanpreston
Copy link
Contributor Author

I suspect they might be. Will cc @ThomasLaPiana here so he's aware.

@ThomasLaPiana
Copy link
Contributor

we're on python 3.8, haven't seen this yet but I suspect that it's related to the python version. I think there were some typing changes made in 3.9 but I might be way off there

@sanders41
Copy link
Contributor

sanders41 commented Apr 13, 2022

@ThomasLaPiana you are correct. The issue seemed to start in 3.9. There are other similar reports around with Pydantic all in 3.9+

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants