Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Enable CI for forked pull requests #26

Closed
pattisdr opened this issue Nov 2, 2021 · 2 comments · Fixed by #86
Closed

Enable CI for forked pull requests #26

pattisdr opened this issue Nov 2, 2021 · 2 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Nov 2, 2021

What

PR's originating from my fidesops fork https://github.com/pattisdr/fidesops did not have CI run for them tests run through github actions, it looks like by default, CircleCI does not build PR's from forked repositories.

There may be some additional configuration to figure out here.

Why

Allows the test suite to run for outside contributors.

👉 EDIT: we don't run tests through circleci, we use github actions, but regardless, tests aren't getting triggered

@pattisdr pattisdr added the enhancement New feature or request label Nov 2, 2021
@pattisdr pattisdr changed the title Enabling CI for forked pull requests Enable CI for forked pull requests Nov 2, 2021
@iamkelllly
Copy link
Contributor

iamkelllly commented Nov 11, 2021

Amended:
Okay so we're using GH actions for triggering CI. I've enabled it for the whole organization (Ethyca) but there's additional config required:

  1. We'll need to update pr_checks.yml to support pull_request_target
  2. Then need to do some acrobatics with a GITHUB_TOKEN with read-only permission, and with no access to secrets. I defer this to @seanpreston to handle.

@pattisdr
Copy link
Contributor Author

To be clear, I think it's our CI that needs to run when a contributor submits a PR from their fork to our repo, so we need to flip some of these settings on our end.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants