Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Create AuditLog event when requests finish processing #1022

Closed
seanpreston opened this issue Aug 2, 2022 · 1 comment · Fixed by #1040
Closed

Create AuditLog event when requests finish processing #1022

seanpreston opened this issue Aug 2, 2022 · 1 comment · Fixed by #1040
Assignees
@TheAndrewJackson
Labels
DSR SLA Countdown enhancement New feature or request

Comments

@seanpreston
Copy link
Contributor

seanpreston commented Aug 2, 2022 •
edited by mfbrown
Loading

When a PrivacyRequest finishes executing successfully, Fidesops should create an AuditLog event to mark the same time as PrivacyRequest.finished_processing_at

Questions

  • should we also create execution log events for other PrivacyRequest.status transitions? If so, maybe this is best implemented as a listener on the PrivacyRequest model rather than in the request's execution.

Notes

  • consider putting in auditlog instead with system user.
@seanpreston seanpreston added the enhancement New feature or request label Aug 3, 2022
@pattisdr
Copy link
Contributor

pattisdr commented Aug 3, 2022 •
edited
Loading

ExecutionLogs currently require a collection_name though - can we separately have a different set of logs for privacy requests overall?

@TheAndrewJackson TheAndrewJackson changed the title Create ExecutionLog event when requests finish processing Create AuditLog event when requests finish processing Aug 4, 2022
@TheAndrewJackson TheAndrewJackson mentioned this issue Aug 8, 2022
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheAndrewJackson TheAndrewJackson

Labels
DSR SLA Countdown enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create finished audit log for privacy requests ethyca/fidesops
4 participants
@seanpreston @NevilleS @pattisdr @TheAndrewJackson