Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing the Makefile with nox #518

Closed
ThomasLaPiana opened this issue Apr 26, 2022 · 1 comment · Fixed by #533
Closed

Investigate replacing the Makefile with nox #518

ThomasLaPiana opened this issue Apr 26, 2022 · 1 comment · Fixed by #533
Labels
dev experience Targets the developer experience
Milestone

Comments

@ThomasLaPiana
Copy link
Contributor

Is your feature request related to a specific problem?

Make lacks some features in the programmatic department, and although one can resort to bash it then breaks across platforms. Our Makefile is getting a bit messy/complex and as seen on fidesops, additional python files had to be written due to limited Make functionality.

Describe the solution you'd like

Replace Make as a dev tool with nox. It is purely pythonic, which means we can use the full power of python to handle our dev tasks as well as natively supports things like matrix testing (testing across multiple python versions, for instance).

Describe alternatives you've considered, if any

Continuing to use the Makefile as-is or writing more custom python scripts to deal with additional complexity.

Additional context

This is very much a "does this make sense? Is it feasible?" type of change proposal. I'm not sure how this will look in practice but its worth trying.

@sanders41
Copy link
Contributor

This sounds like a good idea to explore to me. There is a good chance Python developers haven't used Make before so this could be more intuitive for contributors also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience Targets the developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants