From 38c572c1004a062c3ec0203531e484d6b2913793 Mon Sep 17 00:00:00 2001
From: Allison King <allison@ethyca.com>
Date: Mon, 17 Apr 2023 10:08:07 -0400
Subject: [PATCH] Remove banner with scope migration warning (#3055)

---
 CHANGELOG.md                                                  | 2 ++
 clients/admin-ui/src/features/common/Layout.tsx               | 3 ---
 clients/admin-ui/src/features/common/NotificationBanner.tsx   | 4 ++++
 .../admin-ui/src/features/common/features/features.slice.ts   | 4 ++++
 4 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83e199b37d..1f9589e519 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,8 @@ The types of changes are:
 
 ## [Unreleased](https://github.com/ethyca/fides/compare/2.11.0...main)
 
+### Removed
+- Removed the warning about access control migration [#3055](https://github.com/ethyca/fides/pull/3055)
 
 ## [2.11.0](https://github.com/ethyca/fides/compare/2.10.0...2.11.0)
 
diff --git a/clients/admin-ui/src/features/common/Layout.tsx b/clients/admin-ui/src/features/common/Layout.tsx
index 15040cdf48..8d00ce1359 100644
--- a/clients/admin-ui/src/features/common/Layout.tsx
+++ b/clients/admin-ui/src/features/common/Layout.tsx
@@ -13,7 +13,6 @@ import {
 } from "~/features/privacy-requests/privacy-requests.slice";
 
 import ConfigurationNotificationBanner from "../privacy-requests/configuration/ConfigurationNotificationBanner";
-import NotificationBanner from "./NotificationBanner";
 
 const Layout = ({
   children,
@@ -53,8 +52,6 @@ const Layout = ({
         <link rel="icon" href="/favicon.ico" />
       </Head>
       <Header />
-      {/* TODO: remove this in a future release (see https://github.com/ethyca/fides/issues/2844) */}
-      <NotificationBanner />
       <NavTopBar />
       <Flex as="main" flexGrow={1} padding={10} gap={10}>
         <Box flex={0} flexShrink={0}>
diff --git a/clients/admin-ui/src/features/common/NotificationBanner.tsx b/clients/admin-ui/src/features/common/NotificationBanner.tsx
index bbc3267622..ff8b366ad0 100644
--- a/clients/admin-ui/src/features/common/NotificationBanner.tsx
+++ b/clients/admin-ui/src/features/common/NotificationBanner.tsx
@@ -19,6 +19,10 @@ import {
 const DESCRIPTION =
   "Ethyca has updated how permissions work from a scope-based model to a role-based permissions scheme. To update user roles, please log in as your root user and upgrade the roles as you see fit.";
 
+/**
+ * This component is not currently used, but could easily be used again/modified
+ * if we ever need to show another banner message to a user (see fides#2842)
+ */
 const NotificationBanner = () => {
   const showBanner = useAppSelector(selectShowNotificationBanner);
   const dispatch = useAppDispatch();
diff --git a/clients/admin-ui/src/features/common/features/features.slice.ts b/clients/admin-ui/src/features/common/features/features.slice.ts
index 1ccce1c5f0..6f38200bc0 100644
--- a/clients/admin-ui/src/features/common/features/features.slice.ts
+++ b/clients/admin-ui/src/features/common/features/features.slice.ts
@@ -19,6 +19,10 @@ export const FLAG_NAMES = Object.keys(FLAG_CONFIG) as Array<FlagNames>;
 
 type FeaturesState = {
   flags: Partial<FlagConfig>;
+  /**
+   * Not currently used, but useful for one-time messages that display on every page
+   * until acknowledged (see fides#2842)
+   */
   showNotificationBanner: boolean;
 };