Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

api/http: remove unnecessary conversion #1673

Merged
merged 1 commit into from
Aug 15, 2019
Merged

api/http: remove unnecessary conversion #1673

merged 1 commit into from
Aug 15, 2019

Conversation

skylenet
Copy link
Contributor

fixing linter:

 go run build/ci.go lint

>>> /home/travis/.gimme/versions/go1.12.8.linux.amd64/bin/go get github.com/golangci/golangci-lint/cmd/golangci-lint

>>> /home/travis/gopath/src/github.com/ethersphere/swarm/build/bin/golangci-lint run --tests --deadline=2m --disable-all --enable=goimports --enable=varcheck --enable=vet --enable=gofmt --enable=misspell --enable=goconst ./...

>>> /home/travis/gopath/src/github.com/ethersphere/swarm/build/bin/golangci-lint run --tests --deadline=10m --disable-all --enable=unconvert ./...

api/http/server_test.go:1473:99: unnecessary conversion (unconvert)

	resp, err := http.Post(fmt.Sprintf("%s/bzz-raw:/", srv.URL), "text/plain", bytes.NewReader([]byte(data)))

	                                                                                                 ^

util.go:45: exit status 1

exit status 1

@skylenet skylenet requested review from janos, jmozah and nolash August 15, 2019 08:17
@skylenet skylenet requested a review from acud August 15, 2019 09:06
@skylenet skylenet merged commit 265f0fd into master Aug 15, 2019
@acud acud deleted the lint-conversion branch August 15, 2019 09:08
@skylenet skylenet added this to the 0.5.0 milestone Sep 17, 2019
chadsr added a commit to chadsr/swarm that referenced this pull request Sep 23, 2019
@chadsr
Merge branch 'master' of github.com:ethersphere/swarm
a914e5b 
* 'master' of github.com:ethersphere/swarm:
  chunk, storage: chunk.Store multiple chunk Put (ethersphere#1681)
  storage: fix pyramid chunker and hasherstore possible deadlocks (ethersphere#1679)
  pss: Use distance to determine single guaranteed recipient (ethersphere#1672)
  storage: fix possible hasherstore deadlock on waitC channel (ethersphere#1674)
  network: Add adaptive capabilities message (ethersphere#1619)
  p2p/protocols, p2p/testing; conditional propagation of context (ethersphere#1648)
  api/http: remove unnecessary conversion (ethersphere#1673)
  storage: fix LazyChunkReader.join potential deadlock (ethersphere#1670)
  HTTP API support for pinning contents (ethersphere#1658)
  pot: Add Distance methods with tests (ethersphere#1621)
  README.md: Update Vendored Dependencies section (ethersphere#1667)
  network, p2p, vendor: move vendored p2p/testing under swarm (ethersphere#1647)
  build, vendor: use go modules for vendoring (ethersphere#1532)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acud acud acud approved these changes

@janos janos janos approved these changes

@jmozah jmozah Awaiting requested review from jmozah

@nolash nolash Awaiting requested review from nolash

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skylenet @janos @acud