Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions for ci #853

Closed
wants to merge 3 commits into from

Conversation

ryanio
Copy link

@ryanio ryanio commented May 28, 2020

hey :) I found your gh actions workflow that you mentioned.

I found two things:

  1. actions/checkout was before actions/setup-node
  2. bootstrap was misspelled

I also added your browser tests and made sure the workflow runs on updates to PRs and new tags.

@ricmoo
Copy link
Member

ricmoo commented May 30, 2020

Thanks! :)

I think another problem is I hadn't allowed third-party, which may be required for the checkout/setup actions?

I've added some of your changes for the next push. I'm trying to get the basics working before I enable the browser, because they chew up a lot of CPU time. :)

@ryanio
Copy link
Author

ryanio commented May 30, 2020

@ricmoo
Copy link
Member

ricmoo commented May 30, 2020

Yeah, just saw them. That's awesome. So, I will prolly pull your changes in now... I originally just copied the order their UI build for me.

Few quick questions:

  • Does the filename matter? build.yml vs. nodejs.yml? Or is that just something you already had in another project? Or the recommended standard?
  • What is the easiest way to see how many CI credits I have left?

@ryanio
Copy link
Author

ryanio commented May 30, 2020

Filename doesn't matter but you can customize the name of the workflow and the name of the jobs for how you'd like them to display in the check. also shows in the sidebar here https://github.com/ethers-io/ethers.js/actions

yeah I used my best defaults. also the img src of the readme badge changes with the name: of the workflow. you can use the "Create status badge" btn on the check to generate:

Screen Shot 2020-05-29 at 7 00 48 PM

Free for public repos is pretty amazing 🥇 💯 🔥

Screen Shot 2020-05-29 at 6 55 26 PM

ricmoo added a commit that referenced this pull request May 30, 2020
@ryanio
Copy link
Author

ryanio commented May 30, 2020

It's also trivial to run cron jobs so we have a nightly test run with fresh deps in ethereumjs-vm that's pretty cool (VM Nightly).

@ricmoo
Copy link
Member

ricmoo commented May 30, 2020

So... much... faster. :)

@ryanio
Copy link
Author

ryanio commented May 30, 2020

nice great it's passing! ✅

Node.js CI

@ryanio
Copy link
Author

ryanio commented May 30, 2020

yeah i have no idea how they got it so fast but it's probably the best part

@ryanio ryanio closed this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants