Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhandled promise rejection if a contract is not deployed and a method is called on it #542

Closed
cellog opened this issue Jun 13, 2019 · 2 comments

Comments

@cellog
Copy link

cellog commented Jun 13, 2019

https://github.com/ethers-io/ethers.js/blob/master/src.ts/contract.ts#L184

This needs a catch()

@ricmoo ricmoo added bug Verified to be an issue. investigate Under investigation and may be a bug. and removed bug Verified to be an issue. labels Jul 9, 2019
@ricmoo
Copy link
Member

ricmoo commented Jun 6, 2020

Heya! Closing up some older issues, and came across this one.

I think the call or the send should solve this, no? Since those calls use resolveProperties, which will throw if that throws.

Have you tried this in v5?

@ricmoo
Copy link
Member

ricmoo commented Jul 5, 2020

Closing this now, but please feel free to re-open if there is still any issue.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants