fixed provider-jsonrpc.ts strict compile fixes and error handling #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror handling on network_error) The original condition used "NETWORK_ERROR" || isError(error, "UNSUPPORTED_OPERATION") which is always truthy due to the way the logical OR operator (||) is evaluated. This caused the if statement to not function as intended, potentially resulting in unexpected rejections during transaction handling.
ricmoo
added
bug
|
Sorry this slipped through the cracks. I'm looking into it now. |
ricmoo
added a commit
that referenced
this pull request
Oct 10, 2024
|
This has been fixed in v6.13.4. Thanks! And sorry for the delay. |
ricmoo
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original condition used "NETWORK_ERROR" || isError(error, "UNSUPPORTED_OPERATION") which is always truthy due to the way the logical OR operator (||) is evaluated. This caused the if statement to not function as intended, potentially resulting in unexpected rejections during transaction handling.