-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing JsonRpcApiProviderOptions to BrowserProvider #4707
Conversation
hi @ricmoo any chance you'd be able to look at this simple PR for inclusion to a tiny release..? |
It’s scheduled for the next minor release, which should be coming soon. I can prolly get it out this week. I’ll get the changes merged today into the minor wip branch. :) |
amazing thank you |
hi @ricmoo sorry to be a bother, just wondering if you had a chance to look at this PR yet? |
Sorry, got stuck on a Geth config update for geth-run-action. I’ve fixed the start-up issue, but now I’m getting this error, “transaction indexing is in progress“ during If anyone can help out with this, that would be a huge help. Otherwise I’m hoping to resolve this tonight. :) |
Quick question, if someone could get back to me ASAP; what parameter are you trying to override? I'm thinking of restricting it to the subset of options that makes sense (i.e. remove all the batching properties), but want to make sure that doesn't break your intention. Thanks! :) |
we need it to pass |
Perfect! Thanks. :) |
This has been published in v6.13.0. Try it out and let me know if there are any problems. Thanks! :) |
Removed build artifacts from PR. replaces #4642