-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make Interface.from() Full Clone #4689
Conversation
This should only happen when using 2 different versions of v6, since the first check is |
Fixed in v6.12.1. Let me know if you still have any issues. Thanks! :) |
Yeah it was rare, I encountered it importing between two projects (where I'm testing local changes in one NPM package from another package before release.) Thanks for the fix! |
Interface.format("json")
in v6 implies "minimal" which causesInterface.from()
to drop a lot of meta information.Instead, arg-less
format()
should be called.In v5, it's safe to call arg-less
format()
, as the default isFull
https://github.com/ethers-io/ethers.js/blob/555f16ce7bc6f5fcb40f4c88037f3e4e4182c36c/
Alternatively, this could do an additional check for
formatJson()
from v6.