Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getDefaultProvider types #4501

Closed
wants to merge 1 commit into from
Closed

Conversation

nelkor
Copy link

@nelkor nelkor commented Dec 11, 2023

I'm using ethers + typescript and I'm forced to call the provider this way:

const provider = ethers.getDefaultProvider(null as unknown as string)

The problem is that getDefaultProvider types require passing a first argument, although in fact it is optional. As a result, I have to cheat with typescript just to run the code. I add just one character to the codebase and the first argument becomes optional, which it really is. This seems to improve the development experience, take a look at the new code:

const provider = ethers.getDefaultProvider()

The first argument to the function was actually optional, but had a required type.
@ricmoo ricmoo changed the title 🐛 Improve getDefaultProvider types Improve getDefaultProvider types Feb 1, 2024
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. v6 Issues regarding v6 next-patch Issues scheduled for the next arch release. labels Feb 1, 2024
@ricmoo
Copy link
Member

ricmoo commented Feb 9, 2024

Merged into v6.11.0.

Thanks! :)

@ricmoo ricmoo closed this Feb 9, 2024
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants