Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regexType should have an ending $ #3728

Closed
wants to merge 1 commit into from
Closed

fix: regexType should have an ending $ #3728

wants to merge 1 commit into from

Conversation

zfy0701
Copy link

@zfy0701 zfy0701 commented Feb 3, 2023

No description provided.

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2023

Great catch! Thanks!

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. v6 Issues regarding v6 labels Feb 3, 2023
@zfy0701
Copy link
Author

zfy0701 commented Feb 3, 2023

without this, code like this will fail
contract['interestApr()']

because
FunctionFragment.from("interestApr()")
fail due to lexer error (treat it as type instead of ID)

@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2023

Yeah. I’ll get a patch release asap.

ricmoo added a commit that referenced this pull request Feb 4, 2023
@ricmoo
Fixed human-readable parser when identifier begins with valid type pr…
522fd16 
…efix (#3728).
@zfy0701 zfy0701 closed this Feb 4, 2023
@ricmoo
Copy link
Member

ricmoo commented Feb 4, 2023

Merged!

Thanks a lot! And extra thanks for identifying the cause. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Feb 23, 2023
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
@ricmoo @Woodpile37
Fixed human-readable parser when identifier begins with valid type pr…
b91bea1 
…efix (ethers-io#3728).
Woodpile37 pushed a commit to Woodpile37/ethers.js that referenced this pull request Jan 14, 2024
@ricmoo @Woodpile37
Fixed human-readable parser when identifier begins with valid type pr…
1fe142e 
…efix (ethers-io#3728).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zfy0701 @ricmoo