Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with serializing tx with null type #1628

Closed
wants to merge 1 commit into from
Closed

Fix issue with serializing tx with null type #1628

wants to merge 1 commit into from

Conversation

FrederikBolding
Copy link

Fixes #1627

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Jun 15, 2021
@ricmoo
Copy link
Member

ricmoo commented Jun 15, 2021

Thanks! I just ran into this on the eip-1559 branch too.

I'll get this merged soon.

ricmoo added a commit that referenced this pull request Jun 24, 2021
@ricmoo
Fixed transaction serialization with explicit null type (#1628).
8277f5a
@ricmoo
Copy link
Member

ricmoo commented Jun 26, 2021

Merged in 5.4.0.

Thanks! :)

@ricmoo ricmoo closed this Jun 26, 2021
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jun 28, 2021
@snyk-bot snyk-bot mentioned this pull request Sep 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot serialize transaction when using valid type
2 participants
@FrederikBolding @ricmoo