Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Handling of LRT Variants in liquifier.sol #34

Open
ByungHeonLEE opened this issue Apr 9, 2024 · 0 comments
Open

Separate Handling of LRT Variants in liquifier.sol #34

ByungHeonLEE opened this issue Apr 9, 2024 · 0 comments

Comments

@ByungHeonLEE
Copy link

TL;DR

The current implementation of liquifier.sol accepts all variants of LRT tokens indiscriminately. While this approach simplifies interactions, it potentially introduces risks and inefficiencies.

Concerns

1. Risk of Storage Mapping Confusion and Dependency Issues

  • The liquifier.sol contract is upgradable, which introduces a risk of storage mapping confusion during upgrades. This confusion could lead to vulnerabilities if not managed carefully.
  • Dependency management becomes more complex

2. Cost Implications of the Current Approach

  • A separate approach, although initially more costly due to deployment expenses, could reduce the frequency of required upgrades and test regarding dependency, not new features

Proposal for Separation

I propose that separate the contract with handling of each LRT in the liquifier.sol contract.

Advantages

  • Enhanced Security: Reduce the risk of storage mapping confusion and make the contract's operation more transparent and safer during upgrades.
  • Reduced operation costs: Each LRT variant would be less dependent on the others, making the system as a whole more modular and easier to upgrade in parts without significant affects.
  • (Potential) Strategical implementation with various combination of LRTs: This modularity leads to flexible approach and combining each others with the same category.
    e.g. Combine LRT with Pendle / Combine LRT with specific L2s

I welcome feedback, suggestions, and further discussions on this proposal from the community and team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant