Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

'0x' should be automatically detected/prepended to transaction data #90

Closed
jwasinger opened this issue Feb 28, 2018 · 2 comments
Closed

'0x' should be automatically detected/prepended to transaction data #90

jwasinger opened this issue Feb 28, 2018 · 2 comments
Labels
effort: E1 hours eval: needs discussion type: feature type: refactor

Comments

@jwasinger
Copy link
Contributor

Ran into this today and it took a little while to figure out because ethereumjs-tx was failing silently in this case. I'll see if there are other fields that have the same issue.
@jwasinger jwasinger self-assigned this Feb 28, 2018
@jwasinger jwasinger removed their assignment Jun 9, 2018
@jwasinger jwasinger mentioned this issue Jun 9, 2018
Closed
@danjm danjm mentioned this issue Mar 31, 2019
Closed
@alcuadrado
Copy link
Member

Hi @jwasinger,

A possible fix local to this library was developed in #144, but after discussing it, we decided to fix this in ethereumjs-util. This alternative fix has already been merged but hasn't been released yet. You can take a look at it here: ethereumjs/ethereumjs-util#197

@alcuadrado
Copy link
Member

I'm closing this issue. If someone encounters this problem after version 2 is released please open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort: E1 hours eval: needs discussion type: feature type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensures all transaction properties that are strings are 0x prefixed ethereumjs/ethereumjs-tx
3 participants
@alcuadrado @holgerd77 @jwasinger