Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify client transports #3069

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Simplify client transports #3069

merged 9 commits into from
Sep 29, 2023

Conversation

acolytec3
Copy link
Contributor

This PR entirely removes the transports CLI parameter and has a number of related changes:

  • Networking (i.e. RLPx server and discv4/dns discovery) is now not activated when --sync=none is passed in the command line
  • Converts the servers property of the Config type into a single server and adjusts related code
  • Removes the transports property from Config cleans up boatloads of tests
    where the transports property was set

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #3069 (2eab383) into master (f99a295) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client 87.78% <76.92%> (-0.04%) ⬇️
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.87% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 90.17% <ø> (ø)
trie 90.55% <ø> (+0.23%) ⬆️
tx 96.36% <ø> (ø)
util 86.97% <ø> (ø)
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 changed the title Simply client transports Simplify client transports Sep 28, 2023
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, super clean implementation and so much removed code, love this! 🤩

Will merge.

@holgerd77 holgerd77 merged commit 001d498 into master Sep 29, 2023
41 of 42 checks passed
@holgerd77 holgerd77 deleted the remove-transports branch September 29, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants