-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECIP-1097 Checkpointing for 51% Attack Resistance #347
ECIP-1097 Checkpointing for 51% Attack Resistance #347
Conversation
a082f56
to
7708e73
Compare
0f4fd34
to
b23eaf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, just a few minor comments.
_specs/51_attack_resistance.md
Outdated
@@ -0,0 +1,282 @@ | |||
--- | |||
ecip: <ECIP number> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ecip: <ECIP number> | |
ecip: 1097 |
Please rename the file to ecip-1097.md
, thanks!
_specs/51_attack_resistance.md
Outdated
@@ -0,0 +1,282 @@ | |||
--- | |||
ecip: <ECIP number> | |||
title: 51% Attack Resistance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give this a less generic title, i.e., Checkpointing and Timestamping.
_specs/51_attack_resistance.md
Outdated
ecip: <ECIP number> | ||
title: 51% Attack Resistance | ||
lang: en | ||
author: Dimitris Karakostas, Radek Tkaczyk, Romain Pellerin, Brian McKenna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add contact information here? either a <mail@address>
or a (@github)
handle?
_specs/51_attack_resistance.md
Outdated
title: 51% Attack Resistance | ||
lang: en | ||
author: Dimitris Karakostas, Radek Tkaczyk, Romain Pellerin, Brian McKenna | ||
discussions-to: https://github.com/ethereumclassic/ECIPs/issues/348 | https://github.com/input-output-hk/ECIPs/issues/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will render on the ECIPs website. Can you decide which link you prefer? It doesn't really matter on which repository the discussion happens. Important is the reader knows where to go.
_specs/51_attack_resistance.md
Outdated
"id": 1 | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proposal lacks a license, please add one or waive rights via CC-0.
_specs/51_attack_resistance.md
Outdated
- Draft solution and the secure algorithm, or equivalent, needs to be formalised | ||
- It may not be possible to prove a satisfactory level of security with this scheme, also to make such a scheme secure will likely increase implementation complexity | ||
|
||
##### Option 3: Auxiliary Security from an External Blockchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does an attacker prevent from creating valid timestamping transactions on Bitcoin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timestamping does not try to prevent anyone from timestamping blocks, it only ensures that a single chain is (irreversibly) accepted as canonical. Once the first block of a specific height is timestamped, then it acts as a checkpoint (regardless of who created it) and no party that follows the timestamping mechanism will revert it in the future (thus preventing deep chain reorgs). In other words, allowing an attacker to timestamp blocks is acceptable under this model; what is not acceptable is reorganizing a block that has been timestamped and has been adopted as the local chain.
Could you attend the public call later today to champion your ECIP? ref #333 |
f6079d9
to
76e5828
Compare
On this 8/28 CDC call it was noted that IOG will be holding a call to specifically talk about this ECIP in detail to the community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
merging as draft |
Still lacks a license.... what do we do now? |
Draft. https://github.com/input-output-hk/ECIPs/blob/51-percent-attack-prevention/_specs/51_attack_resistance.md
Discussion. #348 | input-output-hk#1