Lowercase filenames and add lang attribute to all specs #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YazzyYaz
reviewed
Jun 29, 2019
| @@ -13,20 +13,20 @@ <h2>ECIP Types</h2> | |||
|
|
|||
| <p>ECIPs are separated into a number of types, and each has its own list of ECIPs.</p> | |||
|
|
|||
| <h3>Standard Track ({{site.specs|where:"type","Standards Track"|size}})</h3> | |||
| <h3>Standard Track ({{site.specs|where:"lang","en"|where:"type","Standards Track"|size}})</h3> | |||
There was a problem hiding this comment.
Cool stuff. This will make it easier to add more languages in the future for all of them and explore each ECIP.
phyro
approved these changes
Jun 29, 2019
It's nicer, and EIP repo uses lowercase as well. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langitem to all specs.