Skip to content

Commit

Permalink
Merge pull request #3521 from ethereum/fix/release-tsc-errors
Browse files Browse the repository at this point in the history
Update AbstractProvider and contract.methods TS definitions
  • Loading branch information
ryanio authored May 18, 2020
2 parents 035d11a + 7911e5d commit 58d1f5b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions packages/web3-core/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ export interface AbstractProvider {
sendAsync(payload: JsonRpcPayload, callback: (error: Error | null, result?: JsonRpcResponse) => void): void;
send?(payload: JsonRpcPayload, callback: (error: Error | null, result?: JsonRpcResponse) => void): void;
request?(args: RequestArguments): Promise<any>;
connected?: boolean;
}

export type provider =
Expand Down
4 changes: 1 addition & 3 deletions packages/web3-eth-contract/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ export class Contract {

deploy(options: DeployOptions): ContractSendMethod;

methods: {
[key: string]: ContractSendMethod;
};
methods: any;

once(
event: string,
Expand Down
2 changes: 1 addition & 1 deletion scripts/e2e.geth.automine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ echo " "
# Launch client w/ two unlocked accounts.
# + accounts[0] default geth unlocked bal = ~infinity
# + accounts[1] unlocked, signing password = 'left-hand-of-darkness'
geth-dev-assistant --period 2 --accounts 1 --tag 'stable'
geth-dev-assistant --period 2 --accounts 1 --tag 'v1.9.13'

# Test
GETH_AUTOMINE=true nyc --no-clean --silent _mocha -- \
Expand Down
2 changes: 1 addition & 1 deletion scripts/e2e.geth.instamine.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ echo " "
# Launch client w/ two unlocked accounts.
# + accounts[0] default geth unlocked bal = ~infinity
# + accounts[1] unlocked, bal=50 eth, signing password = 'left-hand-of-darkness'
geth-dev-assistant --accounts 1 --tag 'stable'
geth-dev-assistant --accounts 1 --tag 'v1.9.13'

# Test
GETH_INSTAMINE=true nyc --no-clean --silent _mocha -- \
Expand Down

0 comments on commit 58d1f5b

Please sign in to comment.