New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add workflow for unused dependencies #1430

Open

DoTheBestToGetTheBest wants to merge 2 commits into ethereum:master from DoTheBestToGetTheBest:add-deps-check

DoTheBestToGetTheBest commented Sep 8, 2024

should closes #1418


          Update dependencies.yml

e9ed6ac

DoTheBestToGetTheBest changed the title ~~feat: add workflow for unused dependencies~~ chore(ci): add workflow for unused dependencies


          lint commit messages

ae7ada7

KolbyML requested a review from carver

September 8, 2024 21:12

Member

KolbyML commented Oct 3, 2024

@DoTheBestToGetTheBest sorry for the delay I will take over reviewing this PR.

Could you make udeps run on every PR like this example https://github.com/paradigmxyz/reth/blob/ab069979867087b72c1dfe24b535cd997b3b5f4b/.github/workflows/lint.yml#L133-L144

I know the original issue said make it once a week, but I think it makes sense to run it on every run like we do with our CI / commitlint CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet