Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF is not part of shanghai #1195

Closed
holiman opened this issue Mar 15, 2023 · 5 comments
Closed

EOF is not part of shanghai #1195

holiman opened this issue Mar 15, 2023 · 5 comments

Comments

@holiman
Copy link
Contributor

holiman commented Mar 15, 2023

See e.g. https://github.com/ethereum/tests/blob/develop/BlockchainTests/GeneralStateTests/EIPTests/stEOF/ori/CreateEOF1.json

This test assumes that EOF is part of shanghai, which is not the case. This causes thousands of hive-errors.

Suggested solution: redefine them as either Cancun or some other Fork+Eip combo.

@axic
Copy link
Member

axic commented Mar 15, 2023

@hugo-dc last week has been working on changing every EOF test to Cancun and refilling them. It should be done soon?

First tranche is #1193.

@winsvega
Copy link
Collaborator

The EIPTests folder is about experimental tests. We move it now to a separate folder so not to confuse. This are not mandatory tests. we put a README in the folder. but still it is causing confusion. so all experimental tests (not updated with specs or tests for upcoming EIPS are now in EIPTests folder /src/EIPTestsFiller )
#1192

@holiman any objections?

@holiman
Copy link
Contributor Author

holiman commented Mar 15, 2023

Ah, ok, once it's settled which folder to ignore (the BlockchainTests/GeneralStateTests/EIPTests/ or /EIPTests), ping me and we can make sure that hive also ignores it.

@winsvega
Copy link
Collaborator

tests/EIPTests

@winsvega
Copy link
Collaborator

winsvega commented Mar 15, 2023

now we don't care if it is Shanghai or not. since the meaning of Shanghai in EIPTests is Shanghai+EIPXXXX
the decs who generate tests on custom fork now it. the test hash commit hash. but the dev still has to provide the src of geth where this commit hash comes from (to be able to regenerate the test)

then once the EIP is merged into fork and the tests pass. and we are clear about the specs.
we move tests from EIPTests folder into /tests/GeneralStateTests/Cancun and bc folder accordingly
and that will be required to run by clients and on hive
I also keep track how clients provided t8n's are passing the tests.
I have ethereumjs, geth, besu, nimbus now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants