-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EOF is not part of shanghai #1195
Comments
The EIPTests folder is about experimental tests. We move it now to a separate folder so not to confuse. This are not mandatory tests. we put a README in the folder. but still it is causing confusion. so all experimental tests (not updated with specs or tests for upcoming EIPS are now in EIPTests folder /src/EIPTestsFiller ) @holiman any objections? |
Ah, ok, once it's settled which folder to ignore (the |
tests/EIPTests |
now we don't care if it is Shanghai or not. since the meaning of Shanghai in EIPTests is then once the EIP is merged into fork and the tests pass. and we are clear about the specs. |
See e.g. https://github.com/ethereum/tests/blob/develop/BlockchainTests/GeneralStateTests/EIPTests/stEOF/ori/CreateEOF1.json
This test assumes that EOF is part of shanghai, which is not the case. This causes thousands of hive-errors.
Suggested solution: redefine them as either
Cancun
or some otherFork+Eip
combo.The text was updated successfully, but these errors were encountered: