-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split EIPTests into a different branch so not to confuse #1171
Comments
Totally see the problem. I wonder if these are a bit (too) hidden though if in a separate branch? 🤔 With some risk that people are not using? Maybe there are also other options to explore? Not have the one brilliant idea though yet. |
Another option was to make it be in a separate folder like ExperimentalTests next to GeneralStateTests and BlockchainTests folder |
I vote for this one |
Here is the suggestion:
this way EIPTests remain separate from normal tests. explicitly and never are in subfolder of normal tests. |
here all EIP tests are living in a separate EIPTests folder. both bc and state versions |
tests in EIPTests are experimental and often not refer to updated specs. this leads to confusion.
I prefer to keep develop branch updated to the latest specs of all accepted EIPs.
I Suggest to move EIPTests folder to a separate test branch. and merge experimental tests there
@holiman @marioevz
The text was updated successfully, but these errors were encountered: