Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EIPTests into a different branch so not to confuse #1171

Closed
winsvega opened this issue Feb 28, 2023 · 5 comments
Closed

Split EIPTests into a different branch so not to confuse #1171

winsvega opened this issue Feb 28, 2023 · 5 comments

Comments

@winsvega
Copy link
Collaborator

winsvega commented Feb 28, 2023

tests in EIPTests are experimental and often not refer to updated specs. this leads to confusion.
I prefer to keep develop branch updated to the latest specs of all accepted EIPs.

I Suggest to move EIPTests folder to a separate test branch. and merge experimental tests there

@holiman @marioevz

@holgerd77
Copy link
Contributor

Totally see the problem. I wonder if these are a bit (too) hidden though if in a separate branch? 🤔 With some risk that people are not using? Maybe there are also other options to explore? Not have the one brilliant idea though yet.

@winsvega
Copy link
Collaborator Author

winsvega commented Mar 1, 2023

Another option was to make it be in a separate folder like ExperimentalTests next to GeneralStateTests and BlockchainTests folder

@jangko
Copy link
Contributor

jangko commented Mar 10, 2023

Another option was to make it be in a separate folder like ExperimentalTests next to GeneralStateTests and BlockchainTests folder

I vote for this one

@winsvega
Copy link
Collaborator Author

winsvega commented Mar 13, 2023

Here is the suggestion:

src/EIPTestsFiller   ==>   EIPTests (state test format)
src/EIPTestsFiller   ==>   BlockchainTests/EIPTests/GeneralStateTests (blockchain test format)
src/BlockchainTestsFiller/EIPTests  ==>  BlockchainTests/EIPtests

@jangko @holgerd77

this way EIPTests remain separate from normal tests. explicitly and never are in subfolder of normal tests.

@winsvega
Copy link
Collaborator Author

here all EIP tests are living in a separate EIPTests folder. both bc and state versions
#1192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants