Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Refactorization #896

Closed
1 task done
kuzdogan opened this issue Jan 17, 2023 · 1 comment
Closed
1 task done

Package Refactorization #896

kuzdogan opened this issue Jan 17, 2023 · 1 comment
Assignees

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Jan 17, 2023

Wrapper issue for the ongoing npm package development and refactorization of the Sourcify code accordingly.

The goal is to separate the Sourcify functionality, mainly the verification, into a reusable npm library lib-sourcify. This would enable other applications to easily verify contracts given the metadata+source files, and return a Match.

Then the Sourcify server becomes a wrapper around lib-sourcify for different chains, and saves and serves the contract source files.

Non-exhaustive list of tasks, add tasks as they become apparent through the development:

  • [ ] Write tests for the lib-sourcify package. These should cover the existing ones in the server tests for edge cases such as immutable+factory contracts.
  • [ ] Write tests for the server verification service API endpoints.
  • [ ] Write tests for the server repository service API endpoints.
  • [ ] Add test coverage reports in README for lib-sourcify, server and monitor code.
  • Move the src/ into a server/ folder and move server-only dependencies into its server/package.json

View in Huly HI-360

@kuzdogan
Copy link
Member Author

Closing as completed. Testing related todos will follow up with the coverage report: #937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants