Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress Checksumming in the Lookup UI with the url param #844

Closed
kuzdogan opened this issue Nov 16, 2022 · 1 comment
Closed

Adress Checksumming in the Lookup UI with the url param #844

kuzdogan opened this issue Nov 16, 2022 · 1 comment
Assignees
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Nov 16, 2022

When the user inputs a non-checksummed address to the Lookup UI we automatically checksum it and display the checksummed address in the UI and also in the URL.

  1. user inputs 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2

  2. Result:

    image

However when looking up contracts directly with the URL the address is not checksummed in display, although it is checksummed internally in the server and the correct result is displayed. So it's a display issue

  1. user goes to https://staging.sourcify.dev/#/lookup/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2

  2. Result:

    image

Checksum the addresses also when they are input directly through the URL.

View in Huly HI-381

@kuzdogan kuzdogan added the good first issue Issues to start contributing to the project if you're not familiar with the codebase label Dec 5, 2022
@marcocastignoli marcocastignoli self-assigned this Mar 29, 2023
@marcocastignoli
Copy link
Member

It took me a while because I couldn't replicate the problem...

consider these three examples:

  • 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2
  • 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
  • 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756cc2

the first two work, the last one no. that's weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues to start contributing to the project if you're not familiar with the codebase
Projects
None yet
Development

No branches or pull requests

2 participants