Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making platform binary compilation async #1129

Closed
kuzdogan opened this issue Aug 5, 2023 · 1 comment
Closed

Making platform binary compilation async #1129

kuzdogan opened this issue Aug 5, 2023 · 1 comment

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Aug 5, 2023

We are currently running the compilation in a sync child process which is blocking the whole event loop. This is extremely inefficient.

const shellOutputBuffer = spawnSync(solcPath, ['--standard-json'], {
input: inputStringified,
maxBuffer: 1000 * 1000 * 10,
});

Instead, we should do it async. Started a branch for this. https://github.com/ethereum/sourcify/tree/async-compiler-process

However, since this branch of compilation only runs when there's a platform binary but our Apple M1 machines don't have a suitable binary and always run solc-js. We need to do the development on a Linux machine to develop easier.

View in Huly HI-439

@kuzdogan
Copy link
Member Author

Fixed with #1135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant