Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce blobbasefee #14755

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Introduce blobbasefee #14755

merged 1 commit into from
Jan 12, 2024

Conversation

nikola-matic
Copy link
Collaborator

@nikola-matic nikola-matic commented Dec 25, 2023 •
edited
Loading

Closes: #14742
Depends on: #14743

@nikola-matic nikola-matic added has dependencies The PR depends on other PRs that must be merged first feature labels Dec 25, 2023
@nikola-matic nikola-matic added this to the 0.8.24 milestone Dec 25, 2023
@nikola-matic nikola-matic self-assigned this Dec 25, 2023
@nikola-matic nikola-matic changed the base branch from develop to bump-evmone-and-evmc-to-11 December 26, 2023 07:35
@cameel cameel force-pushed the bump-evmone-and-evmc-to-11 branch 3 times, most recently from 93b8bfa to d5119f7 Compare January 6, 2024 16:29
Base automatically changed from bump-evmone-and-evmc-to-11 to develop January 6, 2024 18:34
@cameel cameel mentioned this pull request Jan 6, 2024
Merged
cameel
cameel reviewed Jan 8, 2024
View reviewed changes
Changelog.md Show resolved Hide resolved
@cameel cameel mentioned this pull request Jan 8, 2024
Merged
@nikola-matic nikola-matic removed the has dependencies The PR depends on other PRs that must be merged first label Jan 9, 2024
@nikola-matic nikola-matic marked this pull request as ready for review January 10, 2024 10:25
@nikola-matic nikola-matic force-pushed the introduce-blobbasefee branch 3 times, most recently from 83c0194 to 984be22 Compare January 10, 2024 11:41
cameel
cameel reviewed Jan 10, 2024
View reviewed changes
docs/using-the-compiler.rst Outdated Show resolved Hide resolved
cameel
cameel previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving since it's good enough, but there are a few small things we could still tweak. See review comments.

We're missing SMTChecker support, but that's not essential for the release. Please just create an issue for it. The implementation would be as for basefee in #11785.

Fuzzer support is also missing and adding it seems fairly trivial (just a change in ossfuzz/protoToYul.cpp), but it's better left to @bshastry since he can verify it's done properly.

docs/units-and-global-variables.rst Show resolved Hide resolved
test/libsolidity/semanticTests/inlineAssembly/blobbasefee_shanghai_function.sol Show resolved Hide resolved
@nikola-matic
Copy link
Collaborator Author

I'm approving since it's good enough, but there are a few small things we could still tweak. See review comments.

We're missing SMTChecker support, but that's not essential for the release. Please just create an issue for it. The implementation would be as for basefee in #11785.

Fuzzer support is also missing and adding it seems fairly trivial (just a change in ossfuzz/protoToYul.cpp), but it's better left to @bshastry since he can verify it's done properly.

Yeah, saw the missing SMT support when initially implementing this last year (was especially evident when greping basefee); I may have even asked (or was planning to and then didn't wanna ping people during Christmas) whose responsibility that is. But yeah, given that I have nothing more pressing to do, I can give it a go in another PR.

@cameel
Copy link
Member

cameel commented Jan 11, 2024

I mean, it's probably something that @pgebal would pick sooner or later. We just need an issue for it.

r0qs
r0qs previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@r0qs r0qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, although I have one last comment.

test/libyul/yulSyntaxTests/blobbasefee_reserved_identifier_post_cancun.yul Show resolved Hide resolved
@nikola-matic nikola-matic mentioned this pull request Jan 11, 2024
Open
@bshastry bshastry mentioned this pull request Jan 12, 2024
Merged
@nikola-matic nikola-matic dismissed stale reviews from r0qs and cameel via f9cf691 January 12, 2024 08:57
cameel
cameel approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge after squashing.

@nikola-matic nikola-matic merged commit 1473ce2 into develop Jan 12, 2024
65 checks passed
@nikola-matic nikola-matic deleted the introduce-blobbasefee branch January 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekpyron ekpyron ekpyron left review comments

@r0qs r0qs r0qs left review comments

@cameel cameel cameel approved these changes

Assignees

@nikola-matic nikola-matic

Labels
feature
Projects
None yet
Milestone
0.8.24
Development

Successfully merging this pull request may close these issues.

Support for BLOBBASEFEE from EIP 7516
4 participants
@nikola-matic @cameel @r0qs @ekpyron