Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Run hardhat tests as a PR check #12165

Merged
merged 1 commit into from
Oct 25, 2021
Merged

[CI] Run hardhat tests as a PR check #12165

merged 1 commit into from
Oct 25, 2021

Conversation

cameel
Copy link
Member

@cameel cameel commented Oct 20, 2021 •
edited
Loading

Fixes #10854.
Depends on NomicFoundation/hardhat#1962. Fixed.
Depends on NomicFoundation/hardhat#1969. Fixed.
Depends on NomicFoundation/hardhat#1974. Fixed.

@cameel cameel self-assigned this Oct 20, 2021
@cameel cameel force-pushed the hardhat-tests-in-ci branch 10 times, most recently from 7e4cc49 to b0a7dcc Compare October 21, 2021 11:07
@cameel
Copy link
Member Author

cameel commented Oct 21, 2021

There are two open hardhat PRs that need to be merged first:

Also, I made it a PR check because it's pretty fast (runs in under a minute) but given that this depends on Hardhat's master branch, maybe it would be better to run it only nightly to avoid accidental breakage blocking our PRs?

@cameel
Copy link
Member Author

cameel commented Oct 22, 2021

All dependent issues have been resolved on Hardhat side and now t_ems_ext_hardhat succeeds so this is now ready for reviews.

@cameel cameel marked this pull request as ready for review October 22, 2021 19:10
@cameel cameel changed the title Run hardhat tests as a PR check [CI] Run hardhat tests as a PR check Oct 22, 2021
@cameel cameel mentioned this pull request Oct 22, 2021
Closed
hrkrshnn
hrkrshnn reviewed Oct 25, 2021
View reviewed changes
.circleci/config.yml
Comment on lines +865 to +867
# NOTE: This is expected to work without running `yarn build` first.
cd hardhat/packages/hardhat-core
yarn test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment #9237 (comment) mentioned running scripts/run-tests-with-custom-solc.sh. Would yarn test also work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking if yarn test is enough or that it should be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. I took these commands from that script. The commands are simple enough that I think that it's better to run them directly. It also makes it possible to have separate steps in CI for more readable output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just looked at the script. Nice.

Marenz
Marenz approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@Marenz Marenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrkrshnn hrkrshnn merged commit ae0db91 into develop Oct 25, 2021
@hrkrshnn hrkrshnn deleted the hardhat-tests-in-ci branch October 25, 2021 11:15
@cameel cameel mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marenz Marenz Marenz approved these changes

@hrkrshnn hrkrshnn hrkrshnn approved these changes

Assignees

@cameel cameel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running Buidler's test suite in our CI
3 participants
@cameel @Marenz @hrkrshnn