Data location not enforced between abstract contract and implementation

[decanus]

Given the following function signature in an abstract contract:

    function _withdraw(
        uint256,
        address,
        uint256,
        bytes memory /* data */
    ) internal virtual;

We would expect that the following code not compile:

    function _withdraw(
        uint256,
        address,
        uint256,
        bytes calldata /* data */
    ) internal override { }

However it does, and when overriding it skews with the values of the previous parameters. The easiest way to prevent this mistake is to not allow changing the storage location.

[cameel]

Are you using the latest compiler? This could be a serious issue with our previous fix, but it's more likely that you're running into this bug that has already been fixed in 0.8.14:

• Bug Concerning Data Location during Inheritance
• Mismatching data locations are allowed in overrides #10900