Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI runs with oldest and latest supported versions of dependencies #670

Open
cameel opened this issue Oct 6, 2022 · 0 comments
Open

CI runs with oldest and latest supported versions of dependencies #670

cameel opened this issue Oct 6, 2022 · 0 comments
Labels
low impact Changes are not very noticeable or potential benefits are limited. medium effort Default level of effort should have We like the idea but it’s not important enough to be a part of the roadmap. testing 🔨

Comments

@cameel
Copy link
Member

cameel commented Oct 6, 2022

As a library, we are committed to supporting whole ranges of dependency versions to give the apps that use solc-js the most flexibility. However, we only really test with a single set of versions versions right now. I think that we should be running the test suite with multiple sets of versions. Doing oldest and latest seems the most reasonable.

The task here is to add variants of node-base job that install those different sets of dependencies. Best if npm or yarn can do that automatically, but if not, we can force that by replacing ^ with = in package.json (with some special care for cases that specify multiple valid versions).

Note that we currently use caching for dependencies and the key is based on package.json (rather than package-lock.json, which is not versioned). This means we're not always using latest versions, but rather the ones that were the latest last time package.json was updated:

- install-dependencies:
cache-id: solc-js

For the test runs added as a part of this task, we'll have to disable this caching.

@cameel cameel added medium effort Default level of effort low impact Changes are not very noticeable or potential benefits are limited. should have We like the idea but it’s not important enough to be a part of the roadmap. testing 🔨 labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact Changes are not very noticeable or potential benefits are limited. medium effort Default level of effort should have We like the idea but it’s not important enough to be a part of the roadmap. testing 🔨
Projects
None yet
Development

No branches or pull requests

1 participant