This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
add resetAccounts, new Account, fix getAccounts on remix-simulator #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iurimatias Have you tried running remix-ide tests by integrating this one. |
|
@Aniket-Engg yes, the sister PR is this one ethereum/remix-ide#2590 (and it needs this for the accounts to work) |
okay |
|
e2e tests were failing on remix-ide pr were failing, trying to fix that |
yann300
approved these changes
Feb 19, 2020
yann300
force-pushed
the
remix_sim_accounts2
branch
2 times, most recently
from
af0f274
to
cef06ab
Compare
yann300
force-pushed
the
remix_sim_accounts2
branch
from
cef06ab
to
c02e90d
Compare
yann300
force-pushed
the
remix_sim_accounts2
branch
from
c02e90d
to
908df84
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ethereum/remix-ide#2590