Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call 95 and 99 #205

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Add call 95 and 99 #205

merged 5 commits into from
Nov 4, 2020

Conversation

edsonayllon
Copy link
Contributor

Please review and merge

2315, 2537 | Accepted for Berlin and YOLO testnet|
2565 | EFI, proposed for Berlin, currently not included in YOLO|
2046 | Proposed for Berlin. Under Discussion to evaluate for adding to Yolo|
EIP-2718 | EFI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EFI, Considered for YOLO v2

2565 | EFI, proposed for Berlin, currently not included in YOLO|
2046 | Proposed for Berlin. Under Discussion to evaluate for adding to Yolo|
EIP-2718 | EFI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIP-2929 | Considered for YOLO v2
EIP-2935 | Considered for YOLO v2


This EIP may supercede other EIPs people have been trying to push historically.

**Alexy**: This EIP introduces a read list. Before we only had a write list. The correct solution I see is, yes increase the gas cost. But instead, introduce a specialized primitive so we can cache.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexey


**Vitalik**: If you want to get the benefit of not double charging ERC20 tokens, you have to redeploy every ERC20 token.

**Alexy**: My main concern isn't performance. My main concern is complexity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexey


**Vitalik**: I see it being less complicated. This uses transaction wide global variables, which are used in refunds, and self destruct. There is value having this out in the fairly short term.

**Alexy**: First of all, is this really important? Do people really do that? If it is, we should introduce a mechanism for that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexey:

- 2718
- 2929
- 2935
- 2711
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2711: is just for discussion and not EFI in this meeting

- 2930
- 2315 (already on YOLOv1)

2 left to talk about: 2565. 2565 is moving into final. The other is 2046. 2929 would supercede 2046. 2046 is pending until 2929 is decided on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James: 1. that matches my notes.
2. left to talk about is 2565.

- 2315 (already on YOLOv1)

2 left to talk about: 2565. 2565 is moving into final. The other is 2046. 2929 would supercede 2046. 2046 is pending until 2929 is decided on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No one opposed going into YOLO v2.

EIP | Status
--|--
2315, 2537 | Accepted for Berlin and YOLO testnet|
2565 | EFI, proposed for Berlin, currently not included in YOLO|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2565 | EFI, proposed for Berlin, considered to be included in YOLO v2|

@edsonayllon edsonayllon changed the title Add call 95 Add call 95 and 99 Nov 4, 2020
@Souptacular Souptacular merged commit e05120b into ethereum:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants